Bug Reports

Re: Comments broken

Prodigal — Mon, 13 Oct 2008 16:41:52 GMT

There's actually already a field like you're talking about, it just has incorrect values in it for the historical comments. I tried Friday to get this fixed using just sql but that didn't work consistently for all projects. I'm going to write a program/script to do this and write the updated values - then we'll have to find some downtime to run the script, because comments come in on projects at a fast clip, and I don't want to have locking issues while its running.

Re: Comments broken

watchout — Sat, 11 Oct 2008 14:33:56 GMT

Quote:

Originally Posted by Prodigal Prodigal" src="/Themes/Common/v6/images/forums/btn-lastpost.gif"/>
Well, its not that simple, since you want your comment to show below the comment its replying to.

I was curious and checked out some comments pages and tried to figure out how it's done internally. It's kind of bugfinding training for me, judging by an error how a system works can come in really handy :)

Ok so by what I've seen you don't calculate the display depth when showing, but when posting a comment, and then save that in the database - thats a great thing I guess - performance-wise.

Ok next step. Since saving the level wouldn't be enough (replies wouldn't show up in the right place) you'll have a "reply to" comment id saved somewhere. To get the right order, you'll probably save their own comment id in the reply to field for top-level comments, this way you only had to sort comment id DESC, reply id DESC.

Right, now we have the mixed comments, and sorting by the reply-to field would do no good since it would only mix up everything again. The first sort by the date field would only do the right order per comment level. So what you need is the right "reply-to" field content. I think there is a way, but I'm not sure how good the performance will be:

make a new dynamic column, get it's contents from an inner join with in inner select of the same table that selects the date and id. Or - most probably better performance-wise - run a nightly job to add this new field, then add it to the select statement, use instead of the reply-to sorting.

So now to conclude: I have to apologize. I was a bit too quick with jumping to conclusions before, the solution is definitely not trivial. Also if I got anything wrong there, please tell me I'd like to know how good my guesses have been... :)

Quote:

Originally Posted by Prodigal Prodigal" src="/Themes/Common/v6/images/forums/btn-lastpost.gif"/>
important issues like authentication and such before I can work on it. Hopefully tomorrow...

ooh yes please, though authentication works quite ok atm (was much worse before) - I think you just have to go to curse.com to get an active session and then you can see curse.com comments on curseforge, or something like that

Re: Comments broken

Prodigal — Fri, 10 Oct 2008 19:51:42 GMT

The reply count has been fixed in the sql queries and will be updated the next time the project is bumped from the caches.

Re: Comments broken

Prodigal — Fri, 10 Oct 2008 04:26:28 GMT

Quote:

Originally Posted by watchout watchout" src="/Themes/Common/v6/images/forums/btn-lastpost.gif"/>

Also changing sortorder is usually not a big deal when working with databases, after all thats one of the most important features of DBMS: to provide data abstraction. If I could guess, previously sorting was by the post ID which is the primary key (so it was implicitly done since most DBMS automagically sort by the primary key), but since the importing was done in the reverse order, now the sorting is wrong. An "order by datefield" would most definitely do the trick if SQL is involved...

Well, its not that simple, since you want your comment to show below the comment its replying to. I have a fix in the works to move around the existing comments, I just have to knock out more important issues like authentication and such before I can work on it. Hopefully tomorrow...

The curseforge iframe is a separate page from the curse comments page and didn't get the update when the curse page was fixed. I'll get that in for the next push.

Re: Comments broken

watchout — Thu, 09 Oct 2008 23:06:41 GMT

ok, then I give you a hint:
it works fine in the curseforge iframe comment box, though there's no "reply to this post" button and replies are not indented but that's another issue...

compare:

http://wow.curse.com/downloads/wow-addons/details/druid-stats-i.aspx
http://wow.curseforge.com/projects/druid-stats-i/ (if you see the imported comments here that is)

Edit: *cries* I'm blind... forget what I wrote there

Also changing sortorder is usually not a big deal when working with databases, after all thats one of the most important features of DBMS: to provide data abstraction. If I could guess, previously sorting was by the post ID which is the primary key (so it was implicitly done since most DBMS automagically sort by the primary key), but since the importing was done in the reverse order, now the sorting is wrong. An "order by datefield" would most definitely do the trick if SQL is involved...

Re: Comments broken

Prodigal — Thu, 09 Oct 2008 18:32:22 GMT

Well for one, I didn't do the comment data import. I assume they are reversed because they were retrieved from the old curse in their display order (latest first), and then inserted into the new site in that order. Obviously the site expects later comments to come after earlier ones.

I'm working on a fix for this in the database, but it is complicated. This was not an issue in the display before because they were sorted by date - but that doesn't work with threaded comments, which is why it appeared to reverse after the threading was put back in.

Xinda, I've pulled up your old project page at http://old.curse.com/downloads/details/9562/?cpage=4#comments and I see that the last comment on your project is the same as the first one (due to the import goofup) on the new site. Both sites show 4 pages (20 per) of comments which implies 72+ comments on both sites, at least with my logic. The issue is with the comment counter on the addon page, which is probably showing replies to the project, and not counting replies to other comments.

Re: Comments broken

Xinda — Thu, 09 Oct 2008 16:00:56 GMT

They ARE deleted.

There were 72+ comments, now the comments-counter counts 46 comments.

The reverse of 72+ comments are still 72+ comments, at least with my logic... ;)

Re: Comments broken

Thalius — Thu, 09 Oct 2008 07:24:05 GMT

Why are they reversed, what can you possibly be thinking or was it just easier to do it that way? It sure does not serve the members or addon developers so let us hope it pleases the site developers. We would not want it to not work for anyone, now would we?

Re: Comments broken

Prodigal — Wed, 08 Oct 2008 23:00:47 GMT

they are not deleted - the comments from the old site are in reverse order

Re: Comments broken

Xinda — Tue, 07 Oct 2008 19:24:50 GMT

The bugs are still there.

- zero'd download counters

- deleted comments (newest comments are dated october 2007).

Re: Comments broken

Prodigal — Mon, 06 Oct 2008 16:38:09 GMT

With some of the performance issues critical for the 3.0 WoW patch under control, I'm going to make time to fix the stairstepping issue today.

Re: Comments broken

Kaelten — Mon, 06 Oct 2008 15:56:48 GMT

Quote:

Originally Posted by Thaoky Thaoky" src="/Themes/Common/v6/images/forums/btn-lastpost.gif"/>

Same here, all comments from my addon's page have disappeared.

http://wow.curse.com/downloads/wow-addons/details/altoholic.aspx

using IE7, tested in IE6 as well, doesn't seem to be browser-related imho.

This may have happened in relation to the projects merging with wowace. it is fixible however.

Re: Comments broken

Thaoky — Mon, 06 Oct 2008 14:55:41 GMT

Same here, all comments from my addon's page have disappeared.

http://wow.curse.com/downloads/wow-addons/details/altoholic.aspx

using IE7, tested in IE6 as well, doesn't seem to be browser-related imho.

Re: Comments broken

teek5449 — Sun, 05 Oct 2008 15:25:13 GMT

Unfortunately when they redesigned the site (BTW I do like the new look) some of the improvememts have caused some browser quirks to really show themselves. Some of the CSS is not quite cross browser friendly. There sill continue to be issues until their developers get enough complaints to make them fix the issues. I use Firefox most of the time and the new look causes many issues that fortunately I can fix on my end by rewriting the page code as I receive it. (yay, Firefox) Most people will just need to just keep letting the Curse developers know what their issues are.All new designs have quirks that will not be found until in a live environments such as it is now.

Re: Comments broken

galmok — Sun, 05 Oct 2008 12:47:13 GMT

It is even worse for addons. Comments appear to be in nearly random order now, and still without any replies. And the download numbers have been reset as well. curse should really start testing before doing stuff...